cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caleb Rackliffe (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12836) Set JOINING mode before executing the pre-join index callback
Date Wed, 26 Oct 2016 02:15:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606539#comment-15606539
] 

Caleb Rackliffe edited comment on CASSANDRA-12836 at 10/26/16 2:15 AM:
-----------------------------------------------------------------------

[~sbtourist] Assuming that {{StorageService#operationMode}} hits {{NORMAL}} in {{setTokens()}},
can't the async callback implementation just verify that it's not still {{STARTING}}? (i.e.
{{executePreJoinTasks()}} must return before {{setTokens()}} is called.)


was (Author: maedhroz):
[~sbtourist] Assuming that {{StorageService#operationMode}} hits {{NORMAL}} in {{setTokens()}},
can't the async callback implementation just verify that it's still {{STARTING}}? (i.e. {{executePreJoinTasks()}}
must return before {{setTokens()}} is called.)

> Set JOINING mode before executing the pre-join index callback
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-12836
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12836
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sergio Bossa
>            Assignee: Sergio Bossa
>
> The pre-join index callback introduced by CASSANDRA-12039 might perform long running
tasks, and given it's blocking, it would be good to set the node in JOINING mode, which currently
only happens in case of bootstrap, so that:
> 1) The mode can be properly read by tools.
> 2) Async callback implementation can read the mode themselves to verify at which point
of the startup process they are executing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message