cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12646) nodetool stopdaemon errors out on stopdaemon
Date Fri, 07 Oct 2016 13:40:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555106#comment-15555106
] 

Alex Petrov commented on CASSANDRA-12646:
-----------------------------------------

We could simplify it a bit if we just use {{ConnectException}} and ignore it, and then output
the "C* has shutdown" message afterwards. This way we don't need to rethrow any IOExceptions
and don't need {{stopdaemon}} variable (as {{jmxc}} would be set only if we have successfully
connected prior to {{close}} call).

> nodetool stopdaemon errors out on stopdaemon
> --------------------------------------------
>
>                 Key: CASSANDRA-12646
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12646
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 3.0.x
>
>
> {{nodetool stopdaemon}} works, but it prints a {{java.net.ConnectException: Connection
refused}} error message in {{NodeProbe.close()}} - which is expected.
> Attached patch prevents that error message (i.e. it expects {{close()}} to fail for {{stopdaemon}}).
> Additionally, on trunk a call to {{DD.clientInit()}} has been added, because {{JVMStabilityInspector.inspectThrowable}}
implicitly requires this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message