cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-12541) Portability Flaw: Locale Dependent Comparison
Date Thu, 20 Oct 2016 04:06:58 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-12541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jeff Jirsa resolved CASSANDRA-12541.
------------------------------------
       Resolution: Fixed
         Reviewer: Jeff Jirsa
    Fix Version/s: 3.10
                   3.0.10

Committed as {{9b356409572298373558fe5cc0e249f63c0d3a93}}


> Portability Flaw: Locale Dependent Comparison
> ---------------------------------------------
>
>                 Key: CASSANDRA-12541
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12541
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Eduardo Aguinaga
>            Priority: Trivial
>             Fix For: 3.0.10, 3.10
>
>         Attachments: CASSANDRA-12541,12542,12543.patch
>
>
> Overview:
> In May through June of 2016 a static analysis was performed on version 3.0.5 of the Cassandra
source code. The analysis included an automated analysis using HP Fortify v4.21 SCA and a
manual analysis utilizing SciTools Understand v4. The results of that analysis includes the
issue below.
> Issue:
> In the file CqlRecordWriter.java on line 128 there is a portability problem with the
call to toLowerCase() because it has different locales which may lead to unexpected output.
This may also circumvent custom validation routines.
> {code:java}
> CqlRecordWriter.java, lines 127-130:
> 127 String cqlQuery = CqlConfigHelper.getOutputCql(conf).trim();
> 128 if (cqlQuery.toLowerCase().startsWith("insert"))
> 129     throw new UnsupportedOperationException("INSERT with CqlRecordWriter is not supported,
please use UPDATE/DELETE statement");
> 130 cql = appendKeyWhereClauses(cqlQuery);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message