cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12502) ColumnIndex does not reuse buffer
Date Tue, 04 Oct 2016 11:16:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429345#comment-15429345
] 

Robert Stupp edited comment on CASSANDRA-12502 at 10/4/16 11:15 AM:
--------------------------------------------------------------------

Ah - sorry for that. Target trunk or 3.8/3.9?

||3.X|[branch|https://github.com/apache/cassandra/compare/cassandra-3.X...snazy:12502-reuse-dob-3.x]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12502-reuse-dob-3.x-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12502-reuse-dob-3.x-dtest/lastSuccessfulBuild/]



was (Author: snazy):
Ah - sorry for that. Target trunk or 3.8/3.9?

||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:12502-reuse-dob-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12502-reuse-dob-trunk-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12502-reuse-dob-trunk-dtest/lastSuccessfulBuild/]


> ColumnIndex does not reuse buffer
> ---------------------------------
>
>                 Key: CASSANDRA-12502
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12502
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Branimir Lambov
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 3.x
>
>
> {{ColumnIndex}} is supposed to be reusing its shallow entry buffer. Instead it always
allocates as {{buffer}} isn't returned [from {{useBuffer}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ColumnIndex.java#L227].
> Additionally, relying on caller to set {{buffer}} after the call is error-prone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message