Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8F67200B91 for ; Wed, 14 Sep 2016 15:21:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E7D5B160AB4; Wed, 14 Sep 2016 13:21:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 628D0160ABA for ; Wed, 14 Sep 2016 15:21:21 +0200 (CEST) Received: (qmail 76956 invoked by uid 500); 14 Sep 2016 13:21:20 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 76925 invoked by uid 99); 14 Sep 2016 13:21:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Sep 2016 13:21:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6D6D92C014D for ; Wed, 14 Sep 2016 13:21:20 +0000 (UTC) Date: Wed, 14 Sep 2016 13:21:20 +0000 (UTC) From: "Berenguer Blasi (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-12598) BailErrorStragery alike for ANTLR grammar parsing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 14 Sep 2016 13:21:22 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-12598: ---------------------------------------- Status: Patch Available (was: Open) > BailErrorStragery alike for ANTLR grammar parsing > ------------------------------------------------- > > Key: CASSANDRA-12598 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12598 > Project: Cassandra > Issue Type: Bug > Components: CQL > Reporter: Berenguer Blasi > Fix For: 3.x > > > CQL parsing is missing a mechanism similar to http://www.antlr.org/api/Java/org/antlr/v4/runtime/BailErrorStrategy.html > This solves: > - Stopping parsing instead of continuing when we've got already an error which is wasteful. > - Any skipped java code tied to 'recovered' missing tokens might later cause java exceptions (think non-init variables, non incremented integers (div by zero), etc.) which will bubble up directly and will hide properly formatted error messages to the user with no indication on what went wrong at all. Just a cryptic NPE i.e -- This message was sent by Atlassian JIRA (v6.3.4#6332)