Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 436C0200B8E for ; Mon, 12 Sep 2016 03:56:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 40C73160AD7; Mon, 12 Sep 2016 01:56:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8796A160AC7 for ; Mon, 12 Sep 2016 03:56:21 +0200 (CEST) Received: (qmail 99640 invoked by uid 500); 12 Sep 2016 01:56:20 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99615 invoked by uid 99); 12 Sep 2016 01:56:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 01:56:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8802B2C1B79 for ; Mon, 12 Sep 2016 01:56:20 +0000 (UTC) Date: Mon, 12 Sep 2016 01:56:20 +0000 (UTC) From: "Stefania (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-12516) Interned column identifiers can be overridden incorrectly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Sep 2016 01:56:22 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482775#comment-15482775 ] Stefania commented on CASSANDRA-12516: -------------------------------------- Patch here, CI still pending: ||3.0||trunk|| |[patch|https://github.com/stef1927/cassandra/commits/12516-3.0]|[patch|https://github.com/stef1927/cassandra/commits/12516]| |[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-testall/]| |[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-dtest/]| > Interned column identifiers can be overridden incorrectly > --------------------------------------------------------- > > Key: CASSANDRA-12516 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12516 > Project: Cassandra > Issue Type: Bug > Reporter: Aleksey Yeschenko > Assignee: Stefania > Fix For: 3.0.x, 3.x > > > As discovered by [~Stefania] in CASSANDRA-12423, our use of {{ColumnIdentifier.internedInstances}} to map byte buffer column names to column identifiers is incorrect. It's possible for two non-equal {{ColumnIdentifier}} instances to have the same {{ByteBuffer}} as raw name, and yet different text representations, due to different column name types, leading to hard to debug correctness issues. > Should either amend the map to have the type as part of the key, or limit the use of that map. -- This message was sent by Atlassian JIRA (v6.3.4#6332)