Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 602F7200B9A for ; Thu, 22 Sep 2016 21:14:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5ECCF160AA9; Thu, 22 Sep 2016 19:14:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9D4CA160AAD for ; Thu, 22 Sep 2016 21:14:22 +0200 (CEST) Received: (qmail 54912 invoked by uid 500); 22 Sep 2016 19:14:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 54831 invoked by uid 99); 22 Sep 2016 19:14:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 19:14:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7921B2C2A63 for ; Thu, 22 Sep 2016 19:14:21 +0000 (UTC) Date: Thu, 22 Sep 2016 19:14:21 +0000 (UTC) From: "Christopher Licata (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-12485) Always require replace_address to replace existing token MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 22 Sep 2016 19:14:23 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514217#comment-15514217 ] Christopher Licata commented on CASSANDRA-12485: ------------------------------------------------- Hey Paulo, I am going to try to take on this task, but I think I am misunderstanding the scenario in which a node will take over the tokens from another node during replacement. Could you please explain it a bit more as this will be my first attempt at a contribution to this project? > Always require replace_address to replace existing token > -------------------------------------------------------- > > Key: CASSANDRA-12485 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12485 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata > Reporter: Paulo Motta > Priority: Minor > Labels: lhf > > CASSANDRA-10134 prevented replace an existing node unless {{\-Dcassandra.replace_address}} or {{\-Dcassandra.allow_unsafe_replace=true}} is specified. > We should extend this behavior to tokens, preventing a node from joining the ring if another node with the same token already existing in the ring, unless {{\-Dcassandra.replace_address}} or {{\-Dcassandra.allow_unsafe_replace=true}} is specified in order to avoid catastrophic scenarios. > One scenario where this can easily happen is if you replace a node with another node with a different IP, and after some time you restart the original node by mistake. The original node will then take over the tokens of the replaced node (since it has a newer gossip generation). -- This message was sent by Atlassian JIRA (v6.3.4#6332)