Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 95513200BAA for ; Thu, 22 Sep 2016 06:09:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 94274160ADB; Thu, 22 Sep 2016 04:09:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 117C9160ADE for ; Thu, 22 Sep 2016 06:09:21 +0200 (CEST) Received: (qmail 20252 invoked by uid 500); 22 Sep 2016 04:09:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 20132 invoked by uid 99); 22 Sep 2016 04:09:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 04:09:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C546E2C2A66 for ; Thu, 22 Sep 2016 04:09:20 +0000 (UTC) Date: Thu, 22 Sep 2016 04:09:20 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10825) OverloadedException is untested MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 22 Sep 2016 04:09:22 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512051#comment-15512051 ] Aleksey Yeschenko commented on CASSANDRA-10825: ----------------------------------------------- Probably since forever. Hilarious. [~appodictic] check 2.2 and 3.0 please, provide patches for both, and run CI on them. Not sure if this is critical enough to go into 2.1 if affected. > OverloadedException is untested > ------------------------------- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths > Reporter: Ariel Weisberg > Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test that it is thrown under expected conditions. If there are behaviors driven by catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)