Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 15 Sep 2016 18:29:20 +0000 (UTC)
From: "Sandeep Tamhankar (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12857633.1440101289000.582903.1473964160663@Atlassian.JIRA>
In-Reply-To: <JIRA.12857633.1440101289000@Atlassian.JIRA>
References: <JIRA.12857633.1440101289000@Atlassian.JIRA> <JIRA.12857633.1440101289917@arcas>
Subject: [jira] [Comment Edited] (CASSANDRA-10145) Change protocol to allow
 sending key space independent of query string
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 15 Sep 2016 18:29:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494152#comment-15494152 ] 

Sandeep Tamhankar edited comment on CASSANDRA-10145 at 9/15/16 6:28 PM:
------------------------------------------------------------------------

poc.patch (with diffs from trunk) adds an optional 'keyspace' argument to the QUERY message. I have verified that it behaves properly in my environment with a modified version of the Ruby driver, but the intent is really to get an initial code review and address questions/concerns I discuss in comments / text annotated with "sandman:". The two main concerns are:
1. What to do with PREPARE messages since they don't currently have a flags byte for optional arguments.
2. Should 0x80 in flags be defined to say "there is another byte of extra-flags; look there for additional optional parameters to this message".

You need not bother running this code; this patch is a partial implementation of this feature and is meant as a proof of concept. Based on feedback and discussion, I'll flesh it out, add tests, etc., and then submit a new patch.


was (Author: stamhankar999):
poc.patch adds an optional 'keyspace' argument to the QUERY message. I have verified that it behaves properly in my environment with a modified version of the Ruby driver, but the intent is really to get an initial code review and address questions/concerns I discuss in comments / text annotated with "sandman:". The two main concerns are:
1. What to do with PREPARE messages since they don't currently have a flags byte for optional arguments.
2. Should 0x80 in flags be defined to say "there is another byte of extra-flags; look there for additional optional parameters to this message".

You need not bother running this code; this patch is a partial implementation of this feature and is meant as a proof of concept. Based on feedback and discussion, I'll flesh it out, add tests, etc., and then submit a new patch.

> Change protocol to allow sending key space independent of query string
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-10145
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10145
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Vishy Kasar
>            Assignee: Sandeep Tamhankar
>             Fix For: 3.x
>
>         Attachments: poc.patch
>
>
> Currently keyspace is either embedded in the query string or set through "use keyspace" on a connection by client driver. 
> There are practical use cases where client user has query and keyspace independently. In order for that scenario to work, they will have to create one client session per keyspace or have to resort to some string replace hackery.
> It will be nice if protocol allowed sending keyspace separately from the query. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)