Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 16B6E200B92 for ; Tue, 13 Sep 2016 15:40:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 13960160AD2; Tue, 13 Sep 2016 13:40:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 633AB160AD8 for ; Tue, 13 Sep 2016 15:40:22 +0200 (CEST) Received: (qmail 80259 invoked by uid 500); 13 Sep 2016 13:40:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 80164 invoked by uid 99); 13 Sep 2016 13:40:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2016 13:40:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 116232C014C for ; Tue, 13 Sep 2016 13:40:21 +0000 (UTC) Date: Tue, 13 Sep 2016 13:40:21 +0000 (UTC) From: "Sergio Bossa (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-9318) Bound the number of in-flight requests at the coordinator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 13 Sep 2016 13:40:23 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487229#comment-15487229 ] Sergio Bossa commented on CASSANDRA-9318: ----------------------------------------- Testing should be now completed and all the main point have been verified: 1) No performance regressions with back-pressure disabled. 2) No performance regressions with back-pressure enabled and normally behaving cluster. 3) Reduced dropped mutations, typically by an order of magnitude, for continuous heavy write workloads, and full recovery via hints: tested with a 4 nodes RF=3 cluster, ByteMan-based rate limiting applied in several scenarios to one or more nodes, and "slow" back-pressure. [~eduard.tudenhoefner], [~rhatch], do you have anything to add? I've also fixed a bug along the way and rebased to the latest trunk: [~Stefania], do you mind to have a final (hopefully!) review? Updated patch and test runs: | [trunk patch|https://github.com/apache/cassandra/compare/trunk...sbtourist:CASSANDRA-9318-trunk?expand=1] | [testall|https://cassci.datastax.com/view/Dev/view/sbtourist/job/sbtourist-CASSANDRA-9318-trunk-testall/] | [dtest|https://cassci.datastax.com/view/Dev/view/sbtourist/job/sbtourist-CASSANDRA-9318-trunk-dtest/] | [dtest (back-pressure enabled)|https://cassci.datastax.com/view/Dev/view/sbtourist/job/sbtourist-CASSANDRA-9318-bp-true-trunk-dtest/] | > Bound the number of in-flight requests at the coordinator > --------------------------------------------------------- > > Key: CASSANDRA-9318 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9318 > Project: Cassandra > Issue Type: Improvement > Components: Local Write-Read Paths, Streaming and Messaging > Reporter: Ariel Weisberg > Assignee: Sergio Bossa > Attachments: 9318-3.0-nits-trailing-spaces.patch, backpressure.png, limit.btm, no_backpressure.png > > > It's possible to somewhat bound the amount of load accepted into the cluster by bounding the number of in-flight requests and request bytes. > An implementation might do something like track the number of outstanding bytes and requests and if it reaches a high watermark disable read on client connections until it goes back below some low watermark. > Need to make sure that disabling read on the client connection won't introduce other issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)