cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
Date Thu, 29 Sep 2016 21:54:21 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534174#comment-15534174
] 

Aleksey Yeschenko commented on CASSANDRA-12681:
-----------------------------------------------

It's breaking the existing contract by not accepting previously accepted values. It's broken
a couple strategy implementations that inherit from NTS in DSE, for one.

But, really, we have rules, and one of them is that only bug fixes go to 3.0.x - and this
isn't a bug fix.

> Reject empty options and invalid DC names in replication configuration while creating
or altering a keyspace.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Distributed Metadata
>            Reporter: Nachiket Patil
>            Assignee: Nachiket Patil
>            Priority: Minor
>             Fix For: 3.0.10, 3.10
>
>         Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class). Cassandra
checks that SimpleStrategy must have replication_factor option but does not check that at
least one DC should be present in the options for NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for NetworkTopologyStrategy
while creating or altering keyspaces. Add a restriction that the options specified is valid
datacenter name. Using incorrect value or simple mistake in typing the DC name can cause outage
in production environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message