cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-12632) Failure in LogTransactionTest.testUnparsableFirstRecord-compression
Date Wed, 28 Sep 2016 04:05:20 GMT


Stefania commented on CASSANDRA-12632:

Thanks for the review! 

The tidiers contain a reference to the parent transaction, and what matters is for this reference
to be released. This is done either by calling {{run()}} or {{abort()}} on the tidiers. So
either we call one of these methods, or we pass the tidier to {{SSTableReader.markObsolete()}},
which takes care of calling {{run()}} when the sstable reference is released. I checked all
the calls to {{LogTransaction.obsoleted()}} in {{LogTransactionTest}}, and it looks good to
me, all tidiers are handled by one of the 3 mechanisms just described.

Unless objections, I'll consider the non binding +1 a full +1 and commit tomorrow; this patch
only modifies a unit test and is border line ninja fix in my opinion.

> Failure in LogTransactionTest.testUnparsableFirstRecord-compression
> -------------------------------------------------------------------
>                 Key: CASSANDRA-12632
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Joel Knighton
>            Assignee: Stefania
>             Fix For: 3.0.x, 3.x
> Stacktrace:
> {code}
> junit.framework.AssertionFailedError: [/home/automaton/cassandra/build/test/cassandra/data:161/TransactionLogsTest/mockcf23-73ad523078d311e6985893d33dad3001/mc-1-big-Index.db,
> 	at org.apache.cassandra.db.lifecycle.LogTransactionTest.assertFiles(
> 	at org.apache.cassandra.db.lifecycle.LogTransactionTest.assertFiles(
> 	at org.apache.cassandra.db.lifecycle.LogTransactionTest.testCorruptRecord(
> 	at org.apache.cassandra.db.lifecycle.LogTransactionTest.testUnparsableFirstRecord(
> {code}
> Example failure:

This message was sent by Atlassian JIRA

View raw message