cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Tolbert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12628) sstabledump should use AbstractType.toJSONString() instead of getString()
Date Sun, 11 Sep 2016 20:59:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482396#comment-15482396
] 

Andy Tolbert commented on CASSANDRA-12628:
------------------------------------------

[wip branch|https://github.com/tolbertam/cassandra/tree/CASSANDRA-12628], needs a bit of testing
so will hold off on attaching a patch until comfortable.  Also noticed that unfrozen UDTs
don't work either, added support for that as well. 

> sstabledump should use AbstractType.toJSONString() instead of getString()
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12628
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12628
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Andy Tolbert
>            Assignee: Andy Tolbert
>            Priority: Minor
>
> Since sstabledump outputs json, it makes sense for it to use {{AbstractType.toJSONString()}}
instead of {{getString()}} as discussed in [CASSANDRA-12594]:
> {quote}
> sstabledump returns JSON and we now have a proper toJSONString() method in AbstractType
that handles that properly so it would make sense to simply use that for everything in sstabledump
in my opinion.
> {quote}
> Doing this should also fix [CASSANDRA-12594].   There may be a few small differences
in the output format, which I will attempt to document here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message