cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Berenguer Blasi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12598) BailErrorStragery alike for ANTLR grammar parsing
Date Wed, 14 Sep 2016 13:20:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490424#comment-15490424
] 

Berenguer Blasi commented on CASSANDRA-12598:
---------------------------------------------

Branch available here: [link|https://github.com/bereng/cassandra/tree/CASSANDRA-12598-trunk_2]

Test all results available here [link|https://cassci.datastax.com/view/Dev/view/bereng/job/bereng-CASSANDRA-12598-trunk_2-testall/2/]
Dtest resultst available here [link|https://cassci.datastax.com/view/Dev/view/bereng/job/bereng-CASSANDRA-12598-trunk_2-dtest/6/]
(Failure looks unrelated, previous commit fails on a different test also)

> BailErrorStragery alike for ANTLR grammar parsing
> -------------------------------------------------
>
>                 Key: CASSANDRA-12598
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12598
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Berenguer Blasi
>             Fix For: 3.x
>
>
> CQL parsing is missing a mechanism similar to http://www.antlr.org/api/Java/org/antlr/v4/runtime/BailErrorStrategy.html
> This solves:
> - Stopping parsing instead of continuing when we've got already an error which is wasteful.
> - Any skipped java code tied to 'recovered' missing tokens might later cause java exceptions
(think non-init variables, non incremented integers (div by zero), etc.) which will bubble
up directly and will hide properly formatted error messages to the user with no indication
on what went wrong at all. Just a cryptic NPE i.e



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message