cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12554) updateJobs in PendingRangeCalculatorService should be decremented in finally block
Date Wed, 14 Sep 2016 19:57:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491311#comment-15491311
] 

Tyler Hobbs commented on CASSANDRA-12554:
-----------------------------------------

The new patch looks good to me.  I've backported this to 2.2 and started CI test runs:

||branch||testall||dtest||
|[CASSANDRA-12554-2.2|https://github.com/thobbs/cassandra/tree/CASSANDRA-12554-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12554-2.2-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12554-2.2-dtest]|
|[CASSANDRA-12554-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-12554-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12554-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12554-3.0-dtest]|
|[CASSANDRA-12554-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-12554-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12554-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12554-trunk-dtest]|

> updateJobs in PendingRangeCalculatorService should be decremented in finally block
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12554
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12554
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: sankalp kohli
>            Assignee: sankalp kohli
>            Priority: Minor
>         Attachments: CASSANDRA_12554_3.0.txt
>
>
> We fixed an issue in CASSANDRA-7390 with MoveTests by adding a count for running jobs.
While looking at the code, I can see that decrement of this counter should be done in finally
block. 
> Also we dont need to change the setRejectedExecutionHandler in CASSANDRA-7390 as we can
change the order of calling increment. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message