cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Batey (JIRA)" <>
Subject [jira] [Comment Edited] (CASSANDRA-12237) Cassandra stress graphing is broken
Date Fri, 02 Sep 2016 07:37:20 GMT


Christopher Batey edited comment on CASSANDRA-12237 at 9/2/16 7:36 AM:

Branch here: 

* The temporary results log contained each line three times                              
* None of the aggregate metrics showed up due to name changes in the logs/stats          
* Auto run results were all the same color as the graph code was looking for a           
log line that the user hadn't specified a thread count was no long there (all            
results ended up with the same name)                                                     
* Only the first aggregates were shown for a multi run       

was (Author: chbatey):
Branch here: 

Commit msg explains all the changes. I found a few more issues before i could get graphs working

> Cassandra stress graphing is broken
> -----------------------------------
>                 Key: CASSANDRA-12237
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Christopher Batey
>            Assignee: Christopher Batey
>             Fix For: 3.x
> Cassandra stress relies on a tmp file with the stress output so it can parse it and put
it the the graph html.
> However the contents of this file is now broken:
> {code}
> Sleeping 2s...Sleeping 2s...
> Sleeping 2s...
> Warming up WRITE with 50000 iterations...Warming up WRITE with 50000 iterations...
> Warming up WRITE with 50000 iterations...
> Running WRITE with 500 threads 10 secondsRunning WRITE with 500 threads 10 seconds
> Running WRITE with 500 threads 10 seconds
> ...
> {code}
> This is as we create a {code}MultiPrintStream{code} that inherits from {code}PrintWriter{code}
and then delegate the call to super as well as a list of other PrintWriters
> The call to super for println comes back into our print method so every line gets logged
multiple times as we do the for (PrintStream s: newStreams) many times.
> We can change this to use composition and use our own interface if we want to use a composite
for logging the results
> This results in the parsing of this file not quite working and the aggregate stats not
working in produced graphs.

This message was sent by Atlassian JIRA

View raw message