cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12060) Establish consistent distinction between non-existing partition and NULL value for LWTs on static columns
Date Thu, 15 Sep 2016 12:10:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493125#comment-15493125
] 

Alex Petrov commented on CASSANDRA-12060:
-----------------------------------------

In this case I think 3.x behaviour is correct: when using {{UPDATE ... IF }}, it returns the
{{[applied]}} column and existing values that caused the transaction to fail, whereas 2.x
returns just {{[applied]}} with {{false}}. 

We can leave the 2.x behaviour unchanged and introduce special-case in dtests or make a 2-line
fix for 2.x like 

{code}
for (Composite prefix : conditions.keySet())
{
    if (prefix.isStatic() && conditions.size() == 1)
        slices[i++] = new ColumnSlice(Composites.EMPTY, Composites.EMPTY);
    else
        slices[i++] = prefix.slice();
}
{code}



> Establish consistent distinction between non-existing partition and NULL value for LWTs
on static columns
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12060
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12060
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>
> When executing following CQL commands: 
> {code}
> CREATE KEYSPACE test WITH replication = {'class': 'NetworkTopologyStrategy', 'datacenter1':
'1' };
> USE test;
> CREATE TABLE testtable (a int, b int, s1 int static, s2 int static, v int, PRIMARY KEY
(a, b));
> INSERT INTO testtable (a,b,s1,s2,v) VALUES (2,2,2,null,2);
> DELETE s1 FROM testtable WHERE a = 2 IF s2 IN (10,20,30);
> {code}
> The output is different between {{2.x}} and {{3.x}}:
> 2.x:
> {code}
> cqlsh:test> DELETE s1 FROM testtable WHERE a = 2 IF s2 = 5;
>  [applied] | s2
> -----------+------
>      False | null
> {code}
> 3.x:
> {code}
> cqlsh:test> DELETE s1 FROM testtable WHERE a = 2 IF s2 = 5;
>  [applied]
> -----------
>      False
> {code}
> {{2.x}} would although return same result if executed on a partition that does not exist
at all:
> {code}
> cqlsh:test> DELETE s1 FROM testtable WHERE a = 5 IF s2 = 5;
>  [applied]
> -----------
>      False
> {code}
> It _might_ be related to static column LWTs, as I could not reproduce same behaviour
with non-static column LWTs. The most recent change was [CASSANDRA-10532], which enabled LWT
operations on static columns with partition keys only. -Another possible relation is [CASSANDRA-9842],
which removed distinction between {{null}} column and non-existing row.- (striked through
since same happens on pre-[CASSANDRA-9842] code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message