Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8195200B8F for ; Fri, 26 Aug 2016 03:41:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E688C160AA5; Fri, 26 Aug 2016 01:41:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3D4BD160ABD for ; Fri, 26 Aug 2016 03:41:22 +0200 (CEST) Received: (qmail 70008 invoked by uid 500); 26 Aug 2016 01:41:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 69940 invoked by uid 99); 26 Aug 2016 01:41:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Aug 2016 01:41:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8D70A2C0159 for ; Fri, 26 Aug 2016 01:41:20 +0000 (UTC) Date: Fri, 26 Aug 2016 01:41:20 +0000 (UTC) From: "Stefania (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-12504) BatchlogManager is shut down twice during drain MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 26 Aug 2016 01:41:23 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12504?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefania updated CASSANDRA-12504: --------------------------------- Resolution: Fixed Fix Version/s: (was: 3.0.x) (was: 3.x) 3.10 3.0.9 Status: Resolved (was: Patch Available) > BatchlogManager is shut down twice during drain > ----------------------------------------------- > > Key: CASSANDRA-12504 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1250= 4 > Project: Cassandra > Issue Type: Bug > Reporter: Alex Petrov > Assignee: Stefania > Priority: Minor > Fix For: 3.0.9, 3.10 > > > {{BatchlogManager}} is shut down twice during in the {{StorageService}}, = once [here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apac= he/cassandra/service/StorageService.java#L4216] and once [here|https://gith= ub.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/St= orageService.java#L4285]. > The first shutdown was already there but the last one seems to have been = added [here|https://github.com/apache/cassandra/commit/53a177a9150586e56408= f25c959f75110a2997e7#diff-b76a607445d53f18a98c9df14323c7ddR3913]. It seems = to be harmless, as it=E2=80=99s not required in stages in-between, so secon= d run would be a no-op. > Following the logic of other shutdown hook, the first one is the good pla= ce for it to be (right before {{HintsService}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332)