Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9F18C200B5C for ; Thu, 11 Aug 2016 18:06:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9DBC0160AB5; Thu, 11 Aug 2016 16:06:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18C3C160A94 for ; Thu, 11 Aug 2016 18:06:21 +0200 (CEST) Received: (qmail 99929 invoked by uid 500); 11 Aug 2016 16:06:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99712 invoked by uid 99); 11 Aug 2016 16:06:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Aug 2016 16:06:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8DE762C02A8 for ; Thu, 11 Aug 2016 16:06:20 +0000 (UTC) Date: Thu, 11 Aug 2016 16:06:20 +0000 (UTC) From: "Branimir Lambov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-12436) Under some races commit log may incorrectly think it has unflushed data MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 11 Aug 2016 16:06:22 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417495#comment-15417495 ] Branimir Lambov commented on CASSANDRA-12436: --------------------------------------------- The dirty set is a single interval, so that it can be easily updated on allocation (from performance point of view it is infeasible to track the dirty positions more closely). If there is a write after the empty memtable's flush, the dirty interval will also cover the commit log positions between the creation of that memtable and its flushing, which will have advanced if writes to other tables happened during that period. The comment is actually accurate, we do remove the tables from the CFS's live list. We no longer remove them from the set to flush + post-flush. > Under some races commit log may incorrectly think it has unflushed data > ----------------------------------------------------------------------- > > Key: CASSANDRA-12436 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12436 > Project: Cassandra > Issue Type: Bug > Reporter: Branimir Lambov > Assignee: Branimir Lambov > Fix For: 3.0.9, 3.9 > > > This can mainfest itself as a "Failed to force-recycle all segments; at least one segment is still in use with dirty CFs." message after CASSANDRA-11828. -- This message was sent by Atlassian JIRA (v6.3.4#6332)