Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 31 Aug 2016 08:56:21 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12996190.1470817648000.456075.1472633781556@Atlassian.JIRA>
In-Reply-To: <JIRA.12996190.1470817648000@Atlassian.JIRA>
References: <JIRA.12996190.1470817648000@Atlassian.JIRA> <JIRA.12996190.1470817648840@arcas>
Subject: [jira] [Commented] (CASSANDRA-12423) Cells missing from compact
 storage table after upgrading from 2.1.9 to 3.7
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 31 Aug 2016 08:56:23 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451634#comment-15451634 ] 

Sylvain Lebresne commented on CASSANDRA-12423:
----------------------------------------------

The patch lgtm logic-wise, but the nit I'd have is that this somewhat specialize the {{CompositeType.deconstruct()}} method for this backward compatibility problem (granted it's only use in {{LegacyLayout}}, but before this patch, the method somewhat made sense as a {{CompositeType}} generic method. not so much anymore). So I'd suggest moving the logic out of {{deconstruct()}} (actually, we could fairly easily ditch {{deconstruct()}} and {{CompositeComponent}} altogether since you can achieve the same results using {{CompositeType.splitName}} and {{CompositeType.lastEOC}} easily, but I'm fine not bothering with that).

> Cells missing from compact storage table after upgrading from 2.1.9 to 3.7
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12423
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12423
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Tomasz Grabiec
>            Assignee: Stefania
>         Attachments: 12423.tar.gz
>
>
> Schema:
> {code}
> create table ks1.test ( id int, c1 text, c2 text, v int, primary key (id, c1, c2)) with compact storage and compression = {'sstable_compression': ''};
> {code}
> sstable2json before upgrading:
> {code}
> [
> {"key": "1",
>  "cells": [["","0",1470761440040513],
>            ["a","asd",2470761440040513,"t",1470764842],
>            ["asd:","0",1470761451368658],
>            ["asd:asd","0",1470761449416613]]}
> ]
> {code}
> Query result with 2.1.9:
> {code}
> cqlsh> select * from ks1.test;
>  id | c1  | c2   | v
> ----+-----+------+---
>   1 |     | null | 0
>   1 | asd |      | 0
>   1 | asd |  asd | 0
> (3 rows)
> {code}
> Query result with 3.7:
> {code}
> cqlsh> select * from ks1.test;
>  id | 6331 | 6332 | v
> ----+------+------+---
>   1 |      | null | 0
> (1 rows)
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)