Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2C361200B74 for ; Wed, 17 Aug 2016 14:23:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2ACFA160A86; Wed, 17 Aug 2016 12:23:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9AC61160A8C for ; Wed, 17 Aug 2016 14:23:21 +0200 (CEST) Received: (qmail 84413 invoked by uid 500); 17 Aug 2016 12:23:20 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 84389 invoked by uid 99); 17 Aug 2016 12:23:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 12:23:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7D7A72C02A6 for ; Wed, 17 Aug 2016 12:23:20 +0000 (UTC) Date: Wed, 17 Aug 2016 12:23:20 +0000 (UTC) From: "Alex Petrov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-12374) Can't rebuild SASI index MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 17 Aug 2016 12:23:22 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-12374: ------------------------------------ Status: Patch Available (was: Open) Fixed, submitting again. > Can't rebuild SASI index > ------------------------ > > Key: CASSANDRA-12374 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12374 > Project: Cassandra > Issue Type: Bug > Reporter: Alex Petrov > Assignee: Alex Petrov > > There's been no real requirement for that so far. > As [~beobal] has pointed out, it's not a big issue, since that only could be needed when index files are lost, data corruption on disk (hardware issue) has occurred or there was a bug that'd require an index rebuild. > During {{rebuild_index}} task, indexes are only "marked" as removed with {{SecondaryIndexManager::markIndexRemoved}} and then {{buildIndexesBlocking}} is called. However, since SASI keeps track of SSTables for the index, it's going to filter them out with {{.filter((sstable) -> !sasi.index.hasSSTable(sstable))}} in {{SASIIndexBuildingSupport}}. > If I understand the logic correctly, we have to "invalidate" (drop data) right before we re-index them. This is also a blocker for [CASSANDRA-11990] since without it we can't have an upgrade path. > I have a patch ready in branch, but since it's a bug, it's better to have it released earlier and for all branches affected. > cc [~xedin] -- This message was sent by Atlassian JIRA (v6.3.4#6332)