Return-Path: <commits-return-177657-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 38E14200B49
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  3 Aug 2016 11:08:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 3761C160A86; Wed,  3 Aug 2016 09:08:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A4F2C160A64
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  3 Aug 2016 11:08:21 +0200 (CEST)
Received: (qmail 85572 invoked by uid 500); 3 Aug 2016 09:08:20 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 85561 invoked by uid 99); 3 Aug 2016 09:08:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 09:08:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 75F9E2C0D5F
	for <commits@cassandra.apache.org>; Wed,  3 Aug 2016 09:08:20 +0000 (UTC)
Date: Wed, 3 Aug 2016 09:08:20 +0000 (UTC)
From: "Marcus Eriksson (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12994339.1470156553000.210006.1470215300480@Atlassian.JIRA>
In-Reply-To: <JIRA.12994339.1470156553000@Atlassian.JIRA>
References: <JIRA.12994339.1470156553000@Atlassian.JIRA> <JIRA.12994339.1470156553326@arcas>
Subject: [jira] [Commented] (CASSANDRA-12366) Fix compaction throttle
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 03 Aug 2016 09:08:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405602#comment-15405602 ] 

Marcus Eriksson commented on CASSANDRA-12366:
---------------------------------------------

LGTM, just one minor comment;

in {{AbstractCompactionStrategy#getCurrentCompressionRatio()}} - should it calculate the average compression ratio instead of just getting the compression ratio for the last sstable - maybe we could use {{TableMetrics#computeCompressionRatio(Iterable<SSTableReader>...)}}?

> Fix compaction throttle
> -----------------------
>
>                 Key: CASSANDRA-12366
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12366
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: T Jake Luciani
>            Assignee: T Jake Luciani
>             Fix For: 3.x
>
>
> Compaction throttling is broken in the following ways:
>   * It throttles bytes read after being decompressed
>   * Compaction creates multiple scanners which share the rate limiter causing too much throttling
>   * It bears no resemblance to the reported compaction time remaining calculation (Bytes of source sstables processed since start of compaction)
> To fix this we need to simplify the throttling to be only at the CompactionIterator level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)