Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 5 Aug 2016 21:17:20 +0000 (UTC)
From: "Tyler Hobbs (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12992765.1469577433000.238475.1470431840486@Atlassian.JIRA>
In-Reply-To: <JIRA.12992765.1469577433000@Atlassian.JIRA>
References: <JIRA.12992765.1469577433000@Atlassian.JIRA> <JIRA.12992765.1469577433673@arcas>
Subject: [jira] [Commented] (CASSANDRA-12311) Propagate
 TombstoneOverwhelmingException to the client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 05 Aug 2016 21:17:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410079#comment-15410079 ] 

Tyler Hobbs commented on CASSANDRA-12311:
-----------------------------------------

Your latest patch looks good, thank you.

bq. I took a look at the dtests but, since this changes the encoding for the client facing protocol, won't the python driver will need to be changed first to recognize the new failure code map?

Ah, yes, that's a good point.  If you're comfortable with python and would like to open a pull request to add support for this, please feel free to.  Otherwise, I can take care of that pretty quickly.  (Note: any driver work would need to be on top of https://github.com/datastax/python-driver/pull/640 for general protocol v5 support.)

> Propagate TombstoneOverwhelmingException to the client
> ------------------------------------------------------
>
>                 Key: CASSANDRA-12311
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12311
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Geoffrey Yu
>            Assignee: Geoffrey Yu
>            Priority: Minor
>              Labels: client-impacting, doc-impacting
>             Fix For: 4.x
>
>         Attachments: 12311-trunk-v2.txt, 12311-trunk-v3.txt, 12311-trunk-v4.txt, 12311-trunk-v5.txt, 12311-trunk.txt
>
>
> Right now if a data node fails to perform a read because it ran into a {{TombstoneOverwhelmingException}}, it only responds back to the coordinator node with a generic failure. Under this scheme, the coordinator won't be able to know exactly why the request failed and subsequently the client only gets a generic {{ReadFailureException}}. It would be useful to inform the client that their read failed because we read too many tombstones. We should have the data nodes reply with a failure type so the coordinator can pass this information to the client.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)