Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 2 Aug 2016 07:17:20 +0000 (UTC)
From: "Alex Petrov (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12833633.1432861197000.196094.1470122240655@Atlassian.JIRA>
In-Reply-To: <JIRA.12833633.1432861197000@Atlassian.JIRA>
References: <JIRA.12833633.1432861197000@Atlassian.JIRA> <JIRA.12833633.1432861197497@arcas>
Subject: [jira] [Comment Edited] (CASSANDRA-9507) range metrics are not
 updated for timeout and unavailable in StorageProxy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 02 Aug 2016 07:17:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401901#comment-15401901 ] 

Alex Petrov edited comment on CASSANDRA-9507 at 8/2/16 7:16 AM:
----------------------------------------------------------------

Hi [~nachiket_patil], you mentioned that new patches attached, although unfortunately I can still only see patches from 5 of July. I might be missing something. 

Since I could only look at those patches, I have one more comment in addition to what Benjamin has mentioned: do we want to report time as we do with other metircs with {{addNano}} and time diff? 

As a sidenote, as far as I can say this issue does not qualify for "critical", and according to the [discussion|https://mail-archives.apache.org/mod_mbox/cassandra-dev/201607.mbox/%3CCALdd-zjg%2Ba73VncPkU2rw_UpFPVsw0yNwO-yBqUQfK8H8FpiKw%40mail.gmail.com%3E] we probably should leave it out for 2.1.


was (Author: ifesdjeen):
Hi [~nachiket_patil], you mentioned that new patches attached, although unfortunately I can still only see patches from 5 of July. I might be missing something. 

Since I could only look at those patches, I have one more comment in addition to what Benjamin has mentioned: do we want to report time as we do with other metircs with {{addNano}} and time diff? 

As a sidenote, as far as I can say this issue does not qualify for "critical", and according to the [discussion|https://mail-archives.apache.org/mod_mbox/cassandra-dev/201607.mbox/%3CCALdd-zjg%2Ba73VncPkU2rw_UpFPVsw0yNwO-yBqUQfK8H8FpiKw%40mail.gmail.com%3E] we probably should leave it out.

> range metrics are not updated for timeout and unavailable in StorageProxy
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-9507
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability
>            Reporter: sankalp kohli
>            Assignee: Nachiket Patil
>            Priority: Minor
>         Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts and unavailable. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)