cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-12528) Fix eclipse-warning problems
Date Wed, 24 Aug 2016 19:29:20 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sam Tunnicliffe updated CASSANDRA-12528:
----------------------------------------
    Status: Patch Available  (was: In Progress)

There was indeed a large overlap (total in fact) between the branches, so I opted against
splitting into sub-tasks. Mostly the violations were safe so I've added {{@SuppressWarnings}}
annotations for those. The only significant change is to make the threadlocal {{DataOutputBuffer}}
({{scratchBuffer}}) recycle when closed, which lets us use it in try-with-resources blocks.
That last change is in a separate commit on trunk only.

CI is pending, but the eclipse warnings are down to 0 on all branches now.

||branch||testall||dtest||
|[12528-2.2|https://github.com/beobal/cassandra/tree/12528-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12528-2.2-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12528-2.2-dtest]|
|[12528-3.0|https://github.com/beobal/cassandra/tree/12528-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12528-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12528-3.0-dtest]|
|[12528-trunk|https://github.com/beobal/cassandra/tree/12528-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12528-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-12528-trunk-dtest]|

> Fix eclipse-warning problems
> ----------------------------
>
>                 Key: CASSANDRA-12528
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12528
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Joel Knighton
>            Assignee: Sam Tunnicliffe
>
> The {{ant eclipse-warning}} target has accumulated some failures again. Locally, I'm
seeing 3 errors on 2.2, 5 errors on 3.0, 23 errors on 3.9, and 33 errors on trunk.
> Depending on the amount of overlap between these errors, it may make sense to split this
into sub-issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message