cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-12381) Verify use of ByteBuffer.hasArray() in whole code base
Date Thu, 04 Aug 2016 13:45:20 GMT
Robert Stupp created CASSANDRA-12381:
----------------------------------------

             Summary: Verify use of ByteBuffer.hasArray() in whole code base
                 Key: CASSANDRA-12381
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12381
             Project: Cassandra
          Issue Type: Bug
            Reporter: Robert Stupp
            Priority: Minor
             Fix For: 2.1.x


As [noted here|https://docs.oracle.com/javase/8/docs/api/java/nio/ByteBuffer.html#allocateDirect-int-],
a direct {{ByteBuffer}} can have a backing array.

If a direct {{ByteBuffer}} has a backing array, we should not make any assumption on how
it is actually used.

This ticket is about to check whether uses of {{ByteBuffer.hasArray()}} need to be replaced
with {{ByteBuffer.isDirect()}}.

(With CASSANDRA-11870 however, there is no way that such a direct {{ByteBuffer}} has a backing
array.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message