cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12060) Different failure format for failed LWT between 2.x and 3.x
Date Thu, 11 Aug 2016 07:31:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415266#comment-15415266
] 

Alex Petrov edited comment on CASSANDRA-12060 at 8/11/16 7:30 AM:
------------------------------------------------------------------

Talked with [~slebresne] offline, and he suggested to fix the behaviour for all branches as
follows: 

bq. we want x == null to mean "the container of x exists but x itself is null"

  * If partition exists, but column is null, {{= null}} LWT will succeed 
  * If partition does not exist, {{= null}} LWT will fail

|[2.1 |https://github.com/ifesdjeen/cassandra/tree/12060-2.1] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.1-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.1-dtest/]
|
|[2.2 |https://github.com/ifesdjeen/cassandra/tree/12060-2.2] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.2-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.2-dtest/]
|
|[3.0 |https://github.com/ifesdjeen/cassandra/tree/12060-3.0] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-3.0-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-3.0-dtest/]
|
|[trunk |https://github.com/ifesdjeen/cassandra/tree/12060-trunk] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-trunk-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-trunk-dtest/]
|

[dtest branch|https://github.com/ifesdjeen/cassandra-dtest/tree/12060-trunk]


was (Author: ifesdjeen):
Talked with [~slebresne] offline, and he suggested to fix the behaviour for all branches as
follows: 

bq. we want x == null to mean "the container of x exists but x itself is null"

  * If partition exists, but column is null, {{= null}} LWT will succeed 
  * If partition does not exist, {{= null}} LWT will fail

|[2.1 |https://github.com/ifesdjeen/cassandra/tree/12060-2.1] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.1-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.1-dtest/]
|
|[2.2 |https://github.com/ifesdjeen/cassandra/tree/12060-2.2] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.2-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-2.2-dtest/]
|
|[3.0 |https://github.com/ifesdjeen/cassandra/tree/12060-3.0] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-3.0-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-3.0-dtest/]
|
|[trunk |https://github.com/ifesdjeen/cassandra/tree/12060-trunk] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-trunk-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-12060-trunk-dtest/]
|

> Different failure format for failed LWT between 2.x and 3.x
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-12060
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12060
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>
> When executing following CQL commands: 
> {code}
> CREATE KEYSPACE test WITH replication = {'class': 'NetworkTopologyStrategy', 'datacenter1':
'1' };
> USE test;
> CREATE TABLE testtable (a int, b int, s1 int static, s2 int static, v int, PRIMARY KEY
(a, b));
> INSERT INTO testtable (a,b,s1,s2,v) VALUES (2,2,2,null,2);
> DELETE s1 FROM testtable WHERE a = 2 IF s2 IN (10,20,30);
> {code}
> The output is different between {{2.x}} and {{3.x}}:
> 2.x:
> {code}
> cqlsh:test> DELETE s1 FROM testtable WHERE a = 2 IF s2 = 5;
>  [applied] | s2
> -----------+------
>      False | null
> {code}
> 3.x:
> {code}
> cqlsh:test> DELETE s1 FROM testtable WHERE a = 2 IF s2 = 5;
>  [applied]
> -----------
>      False
> {code}
> {{2.x}} would although return same result if executed on a partition that does not exist
at all:
> {code}
> cqlsh:test> DELETE s1 FROM testtable WHERE a = 5 IF s2 = 5;
>  [applied]
> -----------
>      False
> {code}
> It _might_ be related to static column LWTs, as I could not reproduce same behaviour
with non-static column LWTs. The most recent change was [CASSANDRA-10532], which enabled LWT
operations on static columns with partition keys only. -Another possible relation is [CASSANDRA-9842],
which removed distinction between {{null}} column and non-existing row.- (striked through
since same happens on pre-[CASSANDRA-9842] code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message