cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-11990) Address rows rather than partitions in SASI
Date Fri, 05 Aug 2016 13:30:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408322#comment-15408322
] 

Alex Petrov edited comment on CASSANDRA-11990 at 8/5/16 1:29 PM:
-----------------------------------------------------------------

I've tested random partitioner and it (mostly) works, although as suggested I'd highly advise
bringing in support for different partitioners for the next patch. Reason for leaving the
random partitioner out is that the test suite will require quite some refactoring, and current
patch is already quite big. I've implemented a serialization helper that abstracts all the
logic that will be required to implement a fixed-size token reading. For variable-size token
reading we'll have to invest some more work and implement skipping in some reasonable way.

I've implemented the support for reading from old format (ab). Although to make the testing
more complete, I'm going to be working on the upgrade tests for SASI. Also, dtests are missing
for SASI, so I'll create a ticket for that.

|[trunk|https://github.com/ifesdjeen/cassandra/tree/11990-trunk]|[testall|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11182-trunk-testall/]|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11182-trunk-dtest/]|

[CASSANDRA-12389] and [CASSANDRA-12390] to track the follow-up work on supporting different
partitioners.


was (Author: ifesdjeen):
I've tested random partitioner and it (mostly) works, although as suggested I'd highly advise
bringing in support for different partitioners for the next patch. Reason for leaving the
random partitioner out is that the test suite will require quite some refactoring, and current
patch is already quite big. I've implemented a serialization helper that abstracts all the
logic that will be required to implement a fixed-size token reading. For variable-size token
reading we'll have to invest some more work and implement skipping in some reasonable way.

I've implemented the support for reading from old format (ab). Although to make the testing
more complete, I'm going to be working on the upgrade tests for SASI. Also, dtests are missing
for SASI, so I'll create a ticket for that.

|[trunk|https://github.com/ifesdjeen/cassandra/tree/11990-trunk]|[testall|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11182-trunk-testall/]|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11182-trunk-dtest/]|

> Address rows rather than partitions in SASI
> -------------------------------------------
>
>                 Key: CASSANDRA-11990
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11990
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>         Attachments: perf.pdf, size_comparison.png
>
>
> Currently, the lookup in SASI index would return the key position of the partition. After
the partition lookup, the rows are iterated and the operators are applied in order to filter
out ones that do not match.
> bq. TokenTree which accepts variable size keys (such would enable different partitioners,
collections support, primary key indexing etc.), 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message