cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Deng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11865) Improve compaction logging details
Date Fri, 05 Aug 2016 21:21:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410084#comment-15410084
] 

Wei Deng commented on CASSANDRA-11865:
--------------------------------------

[~tjake] and [~carlyeks], I also noticed many of the logger messages in o.a.c.db.compaction.CompactionManager
are missing references to keyspace name and table name, while most of the methods already
have the ColumnFamilyStore object in the context, so they can be easily added as cfs.keyspace.getName(),
cfs.name in the logger calls.

For example, [this log line|https://github.com/apache/cassandra/blob/143d16961a67cc9d5608605ee2561253de629d2c/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L162]
could have printed out the keyspace name and table name to allow people to understand exactly
what table has autocompaction disabled.

Could you add reference to keyspace name and table name whenever possible in our log messages,
as part of your effort for this JIRA?



> Improve compaction logging details
> ----------------------------------
>
>                 Key: CASSANDRA-11865
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11865
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Compaction
>            Reporter: T Jake Luciani
>            Assignee: Carl Yeksigian
>
> I'd like to see per compaction entry:
>   * Partitions processed
>   * Rows processed
>   * Partition merge stats
>   * If a wide row was detected
>   * The partition min/max/avg size
>   * The min/max/avg row count across partitions
> Anything else [~krummas]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message