cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11706) Tracing payload not passed through newSession(..)
Date Thu, 25 Aug 2016 16:10:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437147#comment-15437147
] 

Alex Petrov commented on CASSANDRA-11706:
-----------------------------------------

Unit Test results look good, as {{KeyCacheCqlTest}} is flaky on trunk.

Dtests got broken because of the change in the log format. I've submitted dtest patch [here|https://github.com/riptano/cassandra-dtest/pull/1281]
and re-triggered dtest.

> Tracing payload not passed through newSession(..)
> -------------------------------------------------
>
>                 Key: CASSANDRA-11706
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11706
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: mck
>            Assignee: mck
>            Priority: Minor
>              Labels: tracing
>             Fix For: 3.x
>
>         Attachments: trunk-11706.txt
>
>
> Caused by CASSANDRA-10392
> There's a small bug in https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tracing/Tracing.java#L153
> {noformat}
>     public UUID newSession(UUID sessionId, Map<String,ByteBuffer> customPayload)
>     {
>         return newSession(sessionId, TraceType.QUERY, Collections.EMPTY_MAP);
>     }{noformat}
> in that it passes on an {{EMPTY_MAP}} instead of the {{customPayload}}.
> I've marked this as "minor" as custom tracing plugins can easily enough workaround it
by also overriding the {{newSession(UUID sessionId, Map<String,ByteBuffer> customPayload)}}
method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message