cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremiah Jordan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-9054) Let DatabaseDescriptor not implicitly startup services
Date Fri, 19 Aug 2016 14:30:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427156#comment-15427156
] 

Jeremiah Jordan edited comment on CASSANDRA-9054 at 8/19/16 2:29 PM:
---------------------------------------------------------------------

Was just looking through this.
{{AuthConfig.applyAuthz()}} is called from both {{DatabaseDescriptor.daemonInitialization()}}
and {{CassandraDaemon.applyConfig()}}, which means it gets called twice, as {{applyConfig}}
also calls {{daemonInitialization}}

Also a nit on naming {{applyAuthz}} should probably just be called {{apply}} or {{applyAuth}}
we usually use "Authz" to mean specifically Authori*z*ation, and that method sets up both
Authorization and Authentication.


was (Author: jjordan):
Was just looking through this.
{{AuthConfig.applyAuthz()}} is called from both {{DatabaseDescriptor.daemonInitialization()}}
and {{CassandraDaemon.applyConfig()}}, which means it gets called twice, as {{applyConfig}}
also calls {{daemonInitialization}}

Also a nit on naming {{applyAuthz} should probably just be called {{apply}} or {{applyAuth}}
we usually use "Authz" to mean specifically Authori*z*ation, and that method sets up both
Authorization and Authentication.

> Let DatabaseDescriptor not implicitly startup services
> ------------------------------------------------------
>
>                 Key: CASSANDRA-9054
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9054
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jeremiah Jordan
>            Assignee: Robert Stupp
>             Fix For: 3.10
>
>
> Right now to get at Config stuff you go through DatabaseDescriptor.  But when you instantiate
DatabaseDescriptor it actually opens system tables and such, which triggers commit log replays,
and other things if the right flags aren't set ahead of time.  This makes getting at config
stuff from tools annoying, as you have to be very careful about instantiation orders.
> It would be nice if we could break DatabaseDescriptor up into multiple classes, so that
getting at config stuff from tools wasn't such a pain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message