cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6216) Level Compaction should persist last compacted key per level
Date Tue, 23 Aug 2016 06:40:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432238#comment-15432238
] 

Marcus Eriksson commented on CASSANDRA-6216:
--------------------------------------------

this lgtm with a small change - we should call super.startup() after calculating the last
compacted keys - otherwise (i think) we could start compactions before it has been calculated

I did that and rebased on 3.0 [here|https://github.com/krummas/cassandra/commits/dikang/6216]

tests:
https://cassci.datastax.com/view/Dev/view/krummas/job/krummas-dikang-6216-testall/
https://cassci.datastax.com/view/Dev/view/krummas/job/krummas-dikang-6216-dtest/

will commit when tests have finished successfully

> Level Compaction should persist last compacted key per level
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-6216
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6216
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: sankalp kohli
>            Assignee: Dikang Gu
>            Priority: Minor
>              Labels: compaction, lcs
>         Attachments: JIRA-6216.diff
>
>
> Level compaction does not persist the last compacted key per level. This is important
for higher levels. 
> The sstables with higher token and in higher levels wont get a chance to compact as the
last compacted key will get reset after a restart.    



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message