Return-Path: <commits-return-175093-archive-asf-public=cust-asf.ponee.io@cassandra.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 23D5E200B3C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 13 Jul 2016 11:47:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 1F54A160A7C; Wed, 13 Jul 2016 09:47:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 69435160A57
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 13 Jul 2016 11:47:21 +0200 (CEST)
Received: (qmail 49964 invoked by uid 500); 13 Jul 2016 09:47:20 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 49948 invoked by uid 99); 13 Jul 2016 09:47:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2016 09:47:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 6F1C02C027F
	for <commits@cassandra.apache.org>; Wed, 13 Jul 2016 09:47:20 +0000 (UTC)
Date: Wed, 13 Jul 2016 09:47:20 +0000 (UTC)
From: "Mike Adamson (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12989064.1468402439000.14642.1468403240451@Atlassian.JIRA>
In-Reply-To: <JIRA.12989064.1468402439000@Atlassian.JIRA>
References: <JIRA.12989064.1468402439000@Atlassian.JIRA> <JIRA.12989064.1468402439518@arcas>
Subject: [jira] [Commented] (CASSANDRA-12189) $$ escaped string literals are
 not handled correctly in cqlsh
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 13 Jul 2016 09:47:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374740#comment-15374740 ] 

Mike Adamson commented on CASSANDRA-12189:
------------------------------------------

I have pushed a branch that fixes this to trunk but this is easily portable to previous versions if needed.
||trunk||
|[branch|https://github.com/mike-tr-adamson/cassandra/tree/12189-trunk]|
|[testall|http://cassci.datastax.com/view/Dev/view/madamson/job/mike-tr-adamson-12189-trunk-testall/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/madamson/job/mike-tr-adamson-12189-trunk-dtest/]|


> $$ escaped string literals are not handled correctly in cqlsh
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-12189
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12189
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Mike Adamson
>             Fix For: 3.x
>
>
> The syntax rules for pg ($$) escaped string literals in cqlsh do not match the lexer rule for this type in Lexer.g. 
> The {{unclosedPgString}} rule is not correctly matching pg string literals in multi-line statements so:
> {noformat}
> INSERT INTO test.test (id) values (
> ...$$<xml/>
> {noformat}
> fails with a syntax error at the forward slash.
> Both {{pgStringLiteral}} and {{unclosedPgString}} fail with the following string
> {noformat}
> $$a$b$$
> {noformat}
> where this is allowed by the CQL lexer rule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)