Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 13 Jul 2016 09:39:20 +0000 (UTC)
From: "Hiroyuki Nishi (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12980786.1466415304000.14546.1468402760455@Atlassian.JIRA>
In-Reply-To: <JIRA.12980786.1466415304000@Atlassian.JIRA>
References: <JIRA.12980786.1466415304000@Atlassian.JIRA> <JIRA.12980786.1466415304302@arcas>
Subject: [jira] [Commented] (CASSANDRA-12035) Structure for tpstats output
 (JSON, YAML)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 13 Jul 2016 09:39:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12035?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15374715#comment-15374715 ]=20

Hiroyuki Nishi commented on CASSANDRA-12035:
--------------------------------------------

Hi [~ifesdjeen],

Thank you for your review and refactoring!

I take another look at this code.
=E3=80=80https://github.com/ifesdjeen/cassandra/commit/a46ea376f02245428d05=
c9fb47488102babde4a6

Thereby, I have one question. I could not understand the necessity of toStr=
ing() on below line.
=E3=80=80https://github.com/ifesdjeen/cassandra/blob/12035-trunk/src/java/o=
rg/apache/cassandra/tools/nodetool/stats/TpStatsHolder.java#L48

I don't think I have another problems.

> Structure for tpstats output (JSON, YAML)
> -----------------------------------------
>
>                 Key: CASSANDRA-12035
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1203=
5
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Hiroyuki Nishi
>            Assignee: Hiroyuki Nishi
>            Priority: Minor
>         Attachments: CASSANDRA-12035-trunk.patch, tablestats_result.json,=
 tablestats_result.txt, tablestats_result.yaml, tpstats_output.yaml, tpstat=
s_result.json, tpstats_result.txt, tpstats_result.yaml
>
>
> In CASSANDRA-5977, some extra output formats such as JSON and YAML were a=
dded for nodetool tablestats.=20
> Similarly, I would like to add the output formats in nodetool tpstats.
> Also, I tried to refactor the tablestats's code about the output formats =
to integrate the existing code with my code.
> Please review the attached patch.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)