Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 8 Jul 2016 15:20:11 +0000 (UTC)
From: "Joshua McKenzie (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12979962.1466106190000.57943.1467991211188@Atlassian.JIRA>
In-Reply-To: <JIRA.12979962.1466106190000@Atlassian.JIRA>
References: <JIRA.12979962.1466106190000@Atlassian.JIRA> <JIRA.12979962.1466106190919@arcas>
Subject: [jira] [Commented] (CASSANDRA-12018) CDC follow-ups
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 08 Jul 2016 15:20:14 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12018?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15367801#comment-15367801 ]=20

Joshua McKenzie commented on CASSANDRA-12018:
---------------------------------------------

bq. I would remove the secondary path here =E2=80=93 this could lead to dif=
ferent results between the platforms as one will descend into subdirectorie=
s and the other won't. My problem was with doing both listFiles and walkFil=
eTree, which just doing the walk fixes in the better way (less object churn=
). You can also remove the todo.
Todo removed, and I'm fine normalizing on a single path. While it's slower =
on linux than the one-liner, we're splitting hairs if we're at 500 usec on =
worst-case vs. 400 in a local microbench on a laptop.

bq. The size and unflushedCDCSize members do not need to be atomic, but the=
y should be volatile for writes to be made visible to threads other than th=
e one writing. tempSize isn't informative enough. Maybe sizeInProgress, inc=
ompleteSize or something similar?
Renamed, and the lack of volatile was an oversight on my part. Thanks for c=
atching that.

bq. We still want the AND of global and section-specific flags, just not to=
 carry it over from one section to the other. I.e. statusTracker.tolerateEr=
rorsInSection =3D tolerateTruncation & syncSegment.toleratesErrorsInSection=
 (or make sure the segment reader does it when setting tolerateErrorsInSect=
ion).=20
Changed and commented.

> CDC follow-ups
> --------------
>
>                 Key: CASSANDRA-12018
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1201=
8
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Minor
>
> h6. Platform independent implementation of DirectorySizeCalculator
> On linux, simplify to {{Arrays.stream(path.listFiles()).mapToLong(File::l=
ength).sum();}}
> h6. Refactor DirectorySizeCalculator
> bq. I don't get the DirectorySizeCalculator. Why the alive and visited se=
ts, the listFiles step? Either list the files and just loop through them, o=
r do the walkFileTree operation =E2=80=93 you are now doing the same work t=
wice. Use a plain long instead of the atomic as the class is still thread-u=
nsafe.
> h6. TolerateErrorsInSection should not depend on previous SyncSegment sta=
tus in CommitLogReader
> bq. tolerateErrorsInSection &=3D: I don't think it was intended for the v=
alue to depend on previous iterations.
> h6. Refactor interface of SImpleCachedBufferPool
> bq. SimpleCachedBufferPool should provide getThreadLocalReusableBuffer(in=
t size) which should automatically reallocate if the available size is less=
, and not expose a setter at all.
> h6. Change CDC exception to WriteFailureException instead of WriteTimeout=
Exception
> h6. Remove unused CommitLogTest.testRecovery(byte[] logData)
> h6. NoSpamLogger a message when at CDC capacity


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)