Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 22 Jul 2016 02:24:20 +0000 (UTC)
From: "Stefania (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12973083.1464273301000.102711.1469154260675@Atlassian.JIRA>
In-Reply-To: <JIRA.12973083.1464273301000@Atlassian.JIRA>
References: <JIRA.12973083.1464273301000@Atlassian.JIRA> <JIRA.12973083.1464273301893@arcas>
Subject: [jira] [Comment Edited] (CASSANDRA-11895) dtest failure in
 cqlsh_tests.cqlsh_tests.TestCqlsh.test_unicode_invalid_request_error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 22 Jul 2016 02:24:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388764#comment-15388764 ] 

Stefania edited comment on CASSANDRA-11895 at 7/22/16 2:24 AM:
---------------------------------------------------------------

It's kind of related. The driver is sending us a unicode string for err.message, whilst more recent versions send us a utf-8 encoded string.

We can fix the problem in cqlsh, it happens regardless of the dtest, even locally on my laptop with encoding set to utf-8. The fix is:

{code}
-                self.printerr(str(err.__class__.__name__) + ": " + str(err))
+                self.printerr('%s: %s' % (err.__class__.__name__, err.message.encode(self.encoding)))
{code}

I've created a patch and launched the tests:

|2.1|[patch|https://github.com/stef1927/cassandra/commits/11895-cqlsh-2.1]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11895-cqlsh-2.1-cqlsh-tests/]

Not sure if this is critical enough to be accepted in 2.1. If it isn't I would suggest ignoring the test in 2.1.


was (Author: stefania):
It's kind of related. The driver is sending us a unicode string for err.message, whilst more recent versions send us a utf-8 encoded string.

We can fix the problem in cqlsh, it happens regardless of a dtest, even locally on my laptop with encoding set to utf-8. The fix is:

{code}
-                self.printerr(str(err.__class__.__name__) + ": " + str(err))
+                self.printerr('%s: %s' % (err.__class__.__name__, err.message.encode(self.encoding)))
{code}

I've created a patch and launched the tests:

|2.1|[patch|https://github.com/stef1927/cassandra/commits/11895-cqlsh-2.1]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11895-cqlsh-2.1-cqlsh-tests/]

Not sure if this is critical enough to be accepted in 2.1. If it isn't I would suggest ignoring the test in 2.1.

> dtest failure in cqlsh_tests.cqlsh_tests.TestCqlsh.test_unicode_invalid_request_error
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11895
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11895
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Sean McCarthy
>            Assignee: Michael Shuler
>              Labels: dtest
>         Attachments: node1.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-2.1_dtest/470/testReport/cqlsh_tests.cqlsh_tests/TestCqlsh/test_unicode_invalid_request_error
> Failed on CassCI build cassandra-2.1_dtest #470
> This is after the fix for CASSANDRA-11799.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)