Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 25 Jul 2016 05:39:20 +0000 (UTC)
From: "Stefania (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12954731.1459367198000.119788.1469425160500@Atlassian.JIRA>
In-Reply-To: <JIRA.12954731.1459367198000@Atlassian.JIRA>
References: <JIRA.12954731.1459367198000@Atlassian.JIRA> <JIRA.12954731.1459367198785@arcas>
Subject: [jira] [Commented] (CASSANDRA-11465) dtest failure in
 cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 25 Jul 2016 05:39:22 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391376#comment-15391376 ] 

Stefania commented on CASSANDRA-11465:
--------------------------------------

There's a static method that we won't be able to capture with futures but even the approach based on adding a no op event could have the same race, see CASSANDRA-5668. Basically the state may be deleted before the coordinator receives all responses or even sends all requests but this is not applicable to CL.ALL. Also, the 3.9 patch becomes a little bit more involved due to the abstractions introduced by CASSANDRA-10392.

Launched the tests again, the latest changes are in a separate commit so we can choose which approach to use. I would prefer to use futures since it is more accurate.

||2.2||3.0||3.9||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/11465-cqlsh-2.2]|[patch|https://github.com/stef1927/cassandra/commits/11465-cqlsh-3.0]|[patch|https://github.com/stef1927/cassandra/commits/11465-cqlsh-3.9]|[patch|https://github.com/stef1927/cassandra/commits/11465-cqlsh]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-3.9-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-testall/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-3.9-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11465-cqlsh-dtest/]|

Only the 2.2 and 3.9 commits need reviewing, the 3.0 and trunk commits are identical to the 2.2. and 3.9 commits respectively.

I've also created the pull request for dtests [here|https://github.com/riptano/cassandra-dtest/pull/1125].


> dtest failure in cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11465
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11465
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Stefania
>              Labels: dtest
>
> Failing on the following assert, on trunk only: {{self.assertEqual(len(errs[0]), 1)}}
> Is not failing consistently.
> example failure:
> http://cassci.datastax.com/job/trunk_dtest/1087/testReport/cql_tracing_test/TestCqlTracing/tracing_unknown_impl_test
> Failed on CassCI build trunk_dtest #1087


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)