cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12153) RestrictionSet.hasIN() is slow
Date Fri, 08 Jul 2016 17:56:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368069#comment-15368069
] 

Jeff Jirsa commented on CASSANDRA-12153:
----------------------------------------

Any reason not to do the same with:

https://github.com/thobbs/cassandra/blob/194b56b3c604ed4d6a5a56dcca8c613be13cb8ee/src/java/org/apache/cassandra/cql3/restrictions/ClusteringColumnRestrictions.java#L155

https://github.com/thobbs/cassandra/blob/194b56b3c604ed4d6a5a56dcca8c613be13cb8ee/src/java/org/apache/cassandra/cql3/restrictions/ClusteringColumnRestrictions.java#L166

Then remove {{RestrictionSet stream()}} to discourage this from being reintroduced?


> RestrictionSet.hasIN() is slow
> ------------------------------
>
>                 Key: CASSANDRA-12153
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12153
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Coordination
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>            Priority: Minor
>             Fix For: 3.x
>
>
> While profiling local in-memory reads for CASSANDRA-10993, I noticed that {{RestrictionSet.hasIN()}}
was responsible for about 1% of the time.  It looks like it's mostly slow because it creates
a new LinkedHashSet (which is expensive to init) and uses streams.  This can be replaced with
a simple for loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message