cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-12153) RestrictionSet.hasIN() is slow
Date Tue, 12 Jul 2016 16:21:20 GMT


Tyler Hobbs commented on CASSANDRA-12153:

Nice!  I'm +1 on your code changes.  Can you start a CI test run?

bq. PS: To be honest, I was not expecting that the use of new LinkHashSet, stream() and lambdas
was so bad from a performance point of view. 

I was surprised by how much more expensive it was as well.

> RestrictionSet.hasIN() is slow
> ------------------------------
>                 Key: CASSANDRA-12153
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Coordination
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>            Priority: Minor
>             Fix For: 3.x
> While profiling local in-memory reads for CASSANDRA-10993, I noticed that {{RestrictionSet.hasIN()}}
was responsible for about 1% of the time.  It looks like it's mostly slow because it creates
a new LinkedHashSet (which is expensive to init) and uses streams.  This can be replaced with
a simple for loop.

This message was sent by Atlassian JIRA

View raw message