cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11868) unused imports and generic types
Date Wed, 06 Jul 2016 09:05:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364021#comment-15364021
] 

Alex Petrov commented on CASSANDRA-11868:
-----------------------------------------

[~appodictic] could you remove the annotation flag and unused constant changes and rebase?
I assume you've used some automated tool for that, I would rebase myself otherwise.

> unused imports and generic types
> --------------------------------
>
>                 Key: CASSANDRA-11868
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11868
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>             Fix For: 3.x
>
>
> I was going through Cassandra source and for busy work I started looking at all the .java
files eclipse flags as warning. They are broken roughly into a few cases. 
> 1) unused imports 
> 2) raw types missing <> 
> 3) case statements without defaults 
> 4) @resource annotation 
> My IDE claims item 4 is not needed (it looks like we have done this to signify methods
that return objects that need to be closed) I can guess 4 was done intentionally and short
of making out own annotation I will ignore these for now. 
> I would like to tackle this busy work before I get started. I have some questions: 
> 1) Do this only on trunk? or multiple branches 
> 2) should I tackle 1,2,3 in separate branches/patches



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message