cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11465) dtest failure in cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test
Date Mon, 25 Jul 2016 20:36:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392611#comment-15392611
] 

Paulo Motta commented on CASSANDRA-11465:
-----------------------------------------

New future-based approach LGTM. I added a [new commit|https://github.com/pauloricardomg/cassandra/commit/7246dfbffcb99a6a3f54fef9f84e84072fa90e3c]
to the trunk version simplifying waitForPendingEvents to wait on a list of {{CompletableFuture}}
instead.

bq. Launched the tests again, the latest changes are in a separate commit so we can choose
which approach to use. I would prefer to use futures since it is more accurate.

Since the no-op event solution is a bit simpler and less risky, I propose we commit that for
2.2+ and commit the future-based version only to trunk as an improvement. WDYT ?

Submitted 20x multiplexer run of {{cql_tracing_test.py:TestCqlTracing}} for 2.2 (no-op version)
and trunk (future version):
* [2.2|https://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/186/]
* [trunk|https://cassci.datastax.com/view/Parameterized/job/parameterized_dtest_multiplexer/185/]

> dtest failure in cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11465
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11465
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Stefania
>              Labels: dtest
>
> Failing on the following assert, on trunk only: {{self.assertEqual(len(errs[0]), 1)}}
> Is not failing consistently.
> example failure:
> http://cassci.datastax.com/job/trunk_dtest/1087/testReport/cql_tracing_test/TestCqlTracing/tracing_unknown_impl_test
> Failed on CassCI build trunk_dtest #1087



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message