cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10202) simplify CommitLogSegmentManager
Date Fri, 08 Jul 2016 21:17:11 GMT


Branimir Lambov commented on CASSANDRA-10202:

The above were real problems, code that wasn't correctly updated for the CDC changes. Fixed
 - {{discardSegment(CommitLogSegment)}} _was_ called, but it wasn't using {{discard}},
 - management thread changed to use {{createSegment}} instead of the segment factory to allow
CDC size/type updates,
 - {{discardSegment(File)}} was really unused (renamed in newer code)).

Rebased and re-uploaded at the same location:

Tests look good, but CDC unit tests should have caught the problems above. I will add some
new tests next week (i.e. ticket not ready to commit/review again yet).

> simplify CommitLogSegmentManager
> --------------------------------
>                 Key: CASSANDRA-10202
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>            Reporter: Jonathan Ellis
>            Assignee: Branimir Lambov
>            Priority: Minor
> Now that we only keep one active segment around we can simplify this from the old recycling

This message was sent by Atlassian JIRA

View raw message