cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10202) simplify CommitLogSegmentManager
Date Fri, 08 Jul 2016 21:17:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368493#comment-15368493
] 

Branimir Lambov commented on CASSANDRA-10202:
---------------------------------------------

The above were real problems, code that wasn't correctly updated for the CDC changes. Fixed
now:
 - {{discardSegment(CommitLogSegment)}} _was_ called, but it wasn't using {{discard}},
 - management thread changed to use {{createSegment}} instead of the segment factory to allow
CDC size/type updates,
 - {{discardSegment(File)}} was really unused (renamed in newer code)).

Rebased and re-uploaded at the same location:
|[code|https://github.com/blambov/cassandra/tree/10202-commitlog]|[utest|http://cassci.datastax.com/job/blambov-10202-commitlog-testall/]|[dtest|http://cassci.datastax.com/job/blambov-10202-commitlog-dtest/]|

Tests look good, but CDC unit tests should have caught the problems above. I will add some
new tests next week (i.e. ticket not ready to commit/review again yet).

> simplify CommitLogSegmentManager
> --------------------------------
>
>                 Key: CASSANDRA-10202
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10202
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>            Reporter: Jonathan Ellis
>            Assignee: Branimir Lambov
>            Priority: Minor
>
> Now that we only keep one active segment around we can simplify this from the old recycling
design.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message