cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9054) Break DatabaseDescriptor up into multiple classes.
Date Tue, 19 Jul 2016 00:27:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383365#comment-15383365
] 

Robert Stupp commented on CASSANDRA-9054:
-----------------------------------------

After I've made DD a "non active initializer", it felt too heavy to also break DD into multiple
classes. On the one hand, there's DD but on the other there's {{Config}} - and both are highly
related. I think a better approach would be to move stuff from DD into the appropriate services
- but that's an even more intrusive patch. And I don't know whether it's worth to do that.
What we want to tackle is that accessing DD doesn't "magically" initialize everything in a
more or less "unexpected" order (CASSANDRA-8616, CASSANDRA-9555).

Beside that, I guess, the patch needs a proper rebase.

> Break DatabaseDescriptor up into multiple classes.
> --------------------------------------------------
>
>                 Key: CASSANDRA-9054
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9054
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jeremiah Jordan
>            Assignee: Robert Stupp
>             Fix For: 3.x
>
>
> Right now to get at Config stuff you go through DatabaseDescriptor.  But when you instantiate
DatabaseDescriptor it actually opens system tables and such, which triggers commit log replays,
and other things if the right flags aren't set ahead of time.  This makes getting at config
stuff from tools annoying, as you have to be very careful about instantiation orders.
> It would be nice if we could break DatabaseDescriptor up into multiple classes, so that
getting at config stuff from tools wasn't such a pain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message