cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7190) Add schema to snapshot manifest
Date Fri, 29 Jul 2016 11:52:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399193#comment-15399193
] 

Alex Petrov commented on CASSANDRA-7190:
----------------------------------------

I've fixed the {{DynamicCompositeType}} support. 

As regards the second clause, it refers to the [python driver|https://github.com/datastax/python-driver/blob/master/cassandra/metadata.py#L1061-L1067].
Although I could not construct the table that would fail with this case. 

bq. some cases of mixed dynamic/static Thrift CFs

I've tested several permutation of dynamic/static thrift CFs that were also worked on during
[CASSANDRA-10857] and tried constructing other cases and so far could not find other mismatches.
Might be since Thrift is hiding some or they're being dumped without compact storage.

For example: 

{code}
        CfDef cfDef = new CfDef().setDefault_validation_class(Int32Type.instance.toString())
                                 .setKey_validation_class(AsciiType.instance.toString())
                                 .setComparator_type(CompositeType.getInstance(AsciiType.instance,
AsciiType.instance).toString())
                                 .setColumn_metadata(Arrays.asList(new ColumnDef(CompositeType.build(ByteBufferUtil.bytes("col1"),
ByteBufferUtil.bytes("col1")),
                                                                                 AsciiType.instance.toString()),
                                                                   new ColumnDef(CompositeType.build(ByteBufferUtil.bytes("col2"),
ByteBufferUtil.bytes("col2")),
                                                                                 AsciiType.instance.toString())
                                 ))
                                 .setKeyspace(KEYSPACE)
                                 .setName(TABLE);
{code}

is represented as 

{code}
CREATE TABLE IF NOT EXISTS thrift_created_table_test_ks.test_table_1 (
	key ascii,
	column1 ascii,
	column2 ascii,
	"col1:col1" ascii static,
	"col2:col2" ascii static,
	value int,
	PRIMARY KEY (key, column1, column2))
	WITH ID = d1e70820-5581-11e6-9b6d-53f9c6c224e8
	AND CLUSTERING ORDER BY (column1 ASC, column2 ASC)
{code}

And {{isThriftCompatible}} yields {{false}}, since it's not dense table.

> Add schema to snapshot manifest
> -------------------------------
>
>                 Key: CASSANDRA-7190
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7190
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Alex Petrov
>            Priority: Minor
>              Labels: client-impacting, doc-impacting, lhf
>             Fix For: 3.x
>
>
> followup from CASSANDRA-6326



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message