Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 055CF200B11 for ; Mon, 13 Jun 2016 14:55:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 03EB9160A5B; Mon, 13 Jun 2016 12:55:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5479B160A19 for ; Mon, 13 Jun 2016 14:55:22 +0200 (CEST) Received: (qmail 62952 invoked by uid 500); 13 Jun 2016 12:55:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 62926 invoked by uid 99); 13 Jun 2016 12:55:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 12:55:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 25C8D2C1F6A for ; Mon, 13 Jun 2016 12:55:21 +0000 (UTC) Date: Mon, 13 Jun 2016 12:55:21 +0000 (UTC) From: "Alex Petrov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11868) unused imports and generic types MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Jun 2016 12:55:23 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327297#comment-15327297 ] Alex Petrov commented on CASSANDRA-11868: ----------------------------------------- The only note I currently have is that I'd avoid supressing deprecation warnings. They might be helpful. Let's wait until the [8385|https://issues.apache.org/jira/browse/CASSANDRA-8385] is merged in, rebase and test it thoroughly. > unused imports and generic types > -------------------------------- > > Key: CASSANDRA-11868 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11868 > Project: Cassandra > Issue Type: Improvement > Reporter: Edward Capriolo > Assignee: Edward Capriolo > Fix For: 3.8 > > > I was going through Cassandra source and for busy work I started looking at all the .java files eclipse flags as warning. They are broken roughly into a few cases. > 1) unused imports > 2) raw types missing <> > 3) case statements without defaults > 4) @resource annotation > My IDE claims item 4 is not needed (it looks like we have done this to signify methods that return objects that need to be closed) I can guess 4 was done intentionally and short of making out own annotation I will ignore these for now. > I would like to tackle this busy work before I get started. I have some questions: > 1) Do this only on trunk? or multiple branches > 2) should I tackle 1,2,3 in separate branches/patches -- This message was sent by Atlassian JIRA (v6.3.4#6332)