Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 892EE200B17 for ; Tue, 21 Jun 2016 20:17:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 87AE8160A07; Tue, 21 Jun 2016 18:17:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D2460160A69 for ; Tue, 21 Jun 2016 20:16:59 +0200 (CEST) Received: (qmail 45208 invoked by uid 500); 21 Jun 2016 18:16:58 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 44971 invoked by uid 99); 21 Jun 2016 18:16:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2016 18:16:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 49E992C1F7B for ; Tue, 21 Jun 2016 18:16:58 +0000 (UTC) Date: Tue, 21 Jun 2016 18:16:58 +0000 (UTC) From: "Joel Knighton (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11696) Incremental repairs can mark too many ranges as repaired MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Jun 2016 18:17:00 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342369#comment-15342369 ] Joel Knighton commented on CASSANDRA-11696: ------------------------------------------- I've rebased the branches and run dtests for [2.1|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-11696-2.1-dtest/], [2.2|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-11696-2.2-dtest/], [3.0|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-11696-3.0-dtest/], and [trunk|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-11696-trunk-dtest/]. They all look clean relative to upstream, so all that remains is the few nits above. > Incremental repairs can mark too many ranges as repaired > -------------------------------------------------------- > > Key: CASSANDRA-11696 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11696 > Project: Cassandra > Issue Type: Bug > Reporter: Joel Knighton > Assignee: Marcus Eriksson > Priority: Critical > Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x > > > Incremental repairs are tracked using a parent session - a subordinate repair session is created for each range in the repair. When a node participating in the repair receives a validation request, it will reference the sstables in the parent repair session. When all subordinate sessions conclude, each node anticompacts SSTables based on the parent repair session for the whole range of the repair, but these referenced SSTables may have only been present for the validation of some subset of the ranges because the SSTables were created concurrent with the parent repair session. -- This message was sent by Atlassian JIRA (v6.3.4#6332)