Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 24 Jun 2016 13:18:16 +0000 (UTC)
From: "Alex Petrov (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12913462.1447709765000.21870.1466774296253@Atlassian.JIRA>
In-Reply-To: <JIRA.12913462.1447709765000@Atlassian.JIRA>
References: <JIRA.12913462.1447709765000@Atlassian.JIRA> <JIRA.12913462.1447709765486@arcas>
Subject: [jira] [Commented] (CASSANDRA-10715) Allow filtering on NULL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 24 Jun 2016 13:18:18 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-10715?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15348239#comment-15348239 ]=20

Alex Petrov commented on CASSANDRA-10715:
-----------------------------------------

[~blerer] sure, let me check it out.

> Allow filtering on NULL
> -----------------------
>
>                 Key: CASSANDRA-10715
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1071=
5
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>         Environment: C* 3.0.0 | cqlsh | C# driver 3.0.0beta2 | Windows 20=
12 R2
>            Reporter: Kishan Karunaratne
>            Assignee: Benjamin Lerer
>            Priority: Minor
>              Labels: protocolv5
>             Fix For: 4.0
>
>         Attachments: 0001-Allow-null-values-in-filtered-searches-reuse-Op=
erato.patch
>
>
> This is an issue I first noticed through the C# driver, but I was able to=
 repro on cqlsh, leading me to believe this is a Cassandra bug.
> Given the following schema:
> {noformat}
> CREATE TABLE "TestKeySpace_4928dc892922"."coolMovies" (
>     unique_movie_title text,
>     movie_maker text,
>     director text,
>     list list<text>,
>     "mainGuy" text,
>     "yearMade" int,
>     PRIMARY KEY ((unique_movie_title, movie_maker), director)
> ) WITH CLUSTERING ORDER BY (director ASC)
> {noformat}
> Executing a SELECT with FILTERING on a non-PK column, using a NULL as the=
 argument:
> {noformat}
> SELECT "mainGuy", "movie_maker", "unique_movie_title", "list", "director"=
, "yearMade" FROM "coolMovies" WHERE "mainGuy" =3D null ALLOW FILTERING
> {noformat}
> returns a ReadFailure exception:
> {noformat}
> cqlsh:TestKeySpace_4c8f2cf8d5cc> SELECT "mainGuy", "movie_maker", "unique=
_movie_title", "list", "director", "yearMade" FROM "coolMovies" WHERE "main=
Guy" =3D null ALLOW FILTERING;
> =E2=86=90[0;1;31mTraceback (most recent call last):
>   File "C:\Users\Kishan\.ccm\repository\3.0.0\bin\\cqlsh.py", line 1216, =
in perform_simple_statement
>     result =3D future.result()
>   File "C:\Users\Kishan\.ccm\repository\3.0.0\bin\..\lib\cassandra-driver=
-internal-only-3.0.0a3.post0-3f15725.zip\cassandra-driver-3.0.0a3.post0-3f1=
5725\cassandra\cluster.py", line 3118, in result
>     raise self._final_exception
> ReadFailure: code=3D1300 [Replica(s) failed to execute read] message=3D"O=
peration failed - received 0 responses and 1 failures" info=3D{'failures': =
1, 'received_responses': 0, 'required_responses': 1, 'cons
> istency': 'ONE'}
> =E2=86=90[0m
> {noformat}
> Cassandra log shows:
> {noformat}
> WARN  [SharedPool-Worker-2] 2015-11-16 13:51:00,259 AbstractTracingAwareE=
xecutorService.java:169 - Uncaught exception on thread Thread[SharedPool-Wo=
rker-2,10,main]: {}
> java.lang.AssertionError: null
> =09at org.apache.cassandra.db.filter.RowFilter$SimpleExpression.isSatisfi=
edBy(RowFilter.java:581) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.filter.RowFilter$CQLFilter$1IsSatisfiedFilt=
er.applyToRow(RowFilter.java:243) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.transform.BaseRows.applyOne(BaseRows.java:9=
5) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.transform.BaseRows.add(BaseRows.java:86) ~[=
apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.transform.UnfilteredRows.add(UnfilteredRows=
.java:21) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.transform.Transformation.add(Transformation=
.java:136) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.transform.Transformation.apply(Transformati=
on.java:102) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.filter.RowFilter$CQLFilter$1IsSatisfiedFilt=
er.applyToPartition(RowFilter.java:233) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.filter.RowFilter$CQLFilter$1IsSatisfiedFilt=
er.applyToPartition(RowFilter.java:227) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.transform.BasePartitions.hasNext(BasePartit=
ions.java:76) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Ser=
ializer.serialize(UnfilteredPartitionIterators.java:293) ~[apache-cassandra=
-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadRe=
sponse.java:136) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.ReadResponse$LocalDataResponse.<init>(ReadR=
esponse.java:128) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.ReadResponse$LocalDataResponse.<init>(ReadR=
esponse.java:123) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.ReadResponse.createDataResponse(ReadRespons=
e.java:65) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java=
:288) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayT=
hrow(StorageProxy.java:1692) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(Sto=
rageProxy.java:2346) ~[apache-cassandra-3.0.0.jar:3.0.0]
> =09at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:=
511) ~[na:1.8.0_60]
> =09at org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService=
$FutureTask.run(AbstractTracingAwareExecutorService.java:164) ~[apache-cass=
andra-3.0.0.jar:3.0.0]
> =09at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) [=
apache-cassandra-3.0.0.jar:3.0.0]
> =09at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]
> {noformat}
> In C* < 3.0.0 (such as 2.2.3), this same query correctly returns:
> {noformat}
> cqlsh:TestKeySpace_3231cd551e49> SELECT "mainGuy", "movie_maker", "unique=
_movie_title", "list", "director", "yearMade" FROM "coolMovies" WHERE "main=
Guy" =3D null ALLOW FILTERING;
> =E2=86=90[0;1;31mInvalidRequest: code=3D2200 [Invalid query] message=3D"U=
nsupported null value for indexed column mainGuy"=E2=86=90[0m
> {noformat}
> Not sure if related, but using a value for the argument instead of null r=
eturns 0 rows in 3.0.0, but correctly returns an InvalidRequest exception i=
n C* 2.2.3:
> {noformat}
> SELECT "mainGuy", "movie_maker", "unique_movie_title", "list", "director"=
, "yearMade" FROM "coolMovies" WHERE "yearMade" =3D 100 ALLOW FILTERING
> {noformat}
> In C* 2.2.3:
> {noformat}
> cqlsh:TestKeySpace_4928dc892922> SELECT "mainGuy", "movie_maker", "unique=
_movie_title", "list", "director", "yearMade" FROM "coolMovies" WHERE "year=
Made" =3D 100 ALLOW FILTERING;
> =E2=86=90[0;1;31mInvalidRequest: code=3D2200 [Invalid query] message=3D"N=
o secondary indexes on the restricted columns support the provided operator=
s: "=E2=86=90[0m
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)