cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12034) Special handling for Netty's direct memory allocation failure
Date Wed, 22 Jun 2016 11:10:57 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344128#comment-15344128
] 

Robert Stupp edited comment on CASSANDRA-12034 at 6/22/16 11:10 AM:
--------------------------------------------------------------------

bq. when it will resolve
Good point.
Shall I change the patch to call JVMStabilityInspector? OOMs are not handled there at the
moment (see CASSANDRA-11818).

EDIT: This would become superfluous when we can stream responses and do not allocate buffers
for the whole response and just for individual frames (or however the impl would do it).


was (Author: snazy):
bq. when it will resolve
Good point.
Shall I change the patch to call JVMStabilityInspector? OOMs are not handled there at the
moment (see CASSANDRA-11818).


> Special handling for Netty's direct memory allocation failure
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-12034
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12034
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>             Fix For: 3.x
>
>
> With CASSANDRA-12032, Netty throws a {{io.netty.util.internal.OutOfDirectMemoryError}}
if there's not enough off-heap memory for the response buffer. We can easily handle this situation
and return an error. This is not a condition that destabilizes the system and should therefore
not passed to {{JVMStabilityInspector}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message