cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12013) Optimize the isEOF() checking in RAR
Date Tue, 21 Jun 2016 06:48:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341232#comment-15341232
] 

Stefania commented on CASSANDRA-12013:
--------------------------------------

I ran the utests a few times because of some failures, but they are all accounted for and
pass locally. 

Therefore committed to 2.2. as 68398ada7e35cccc5f3818bb47b741ee25243e08 and merged upwards
with {{-s ours}}.

Thanks for the patch Dikang!

> Optimize the isEOF() checking in RAR
> ------------------------------------
>
>                 Key: CASSANDRA-12013
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12013
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Compaction, Local Write-Read Paths
>            Reporter: Dikang Gu
>            Assignee: Dikang Gu
>            Priority: Minor
>              Labels: compaction
>             Fix For: 2.2.7
>
>         Attachments: 0001-Optimize-the-isEOF-checking-in-RAR.patch, Screenshot 2016-06-15
11.20.51.png
>
>
> When I profile compaction in 2.1, I find the isEOF() is an expensive operation, and we
do the check for each read in RAR, which I think is unnecessary.
> I attach a patch to only check isEOF() when we need to rebuffer, and then I do not see
it from hotspot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message