cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11996) SSTableSet.CANONICAL can miss sstables
Date Wed, 29 Jun 2016 07:27:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354722#comment-15354722
] 

Stefania commented on CASSANDRA-11996:
--------------------------------------

Shouldn't we only return the canonical sstables that are passed into select as a [parameter|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/canonical#diff-6a3c38153a6ec0316c9192d40f71fb40R139]?
By looking [here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/canonical#diff-6a3c38153a6ec0316c9192d40f71fb40R151]
and [here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/canonical#diff-6a3c38153a6ec0316c9192d40f71fb40R159],
won't we return all compacting sstables that are not opened early, regardless of the filter
applied by the callers of select?

In the test, don't we need to call {{DatabaseDescriptor.setSSTablePreempiveOpenIntervalInMB()}}
with a lower interval at the beginning of the test as well?

Nit: in the test, the [runnable|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/canonical#diff-02c4b3ac06af7b36bb219956c41616f6R887]
can be a lambda.

> SSTableSet.CANONICAL can miss sstables
> --------------------------------------
>
>                 Key: CASSANDRA-11996
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11996
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Critical
>             Fix For: 3.0.x, 3.x
>
>
> There is a race where we might miss sstables in SSTableSet.CANONICAL when we finish up
a compaction.
> Reproducing unit test pushed [here|https://github.com/krummas/cassandra/commit/1292aaa61b89730cff0c022ed1262f45afd493e5]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message